Add support for COMMENT property #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
commented
Sep 23, 2022
| @@ -340,6 +343,9 @@ protected function processMessageReply(Message $itipMessage, ?VCalendar $existin | |||
| $requestStatus = $vevent->{'REQUEST-STATUS'}->getValue(); | |||
| list($requestStatus) = explode(';', $requestStatus); | |||
| } | |||
| if(!empty($vevent->{'COMMENT'})) { | |||
| $comments = $vevent->{'COMMENT'}; | |||
There was a problem hiding this comment.
get the value? or use clone?
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
============================================
- Coverage 98.53% 98.27% -0.26%
- Complexity 1865 1876 +11
============================================
Files 71 71
Lines 4159 4178 +19
============================================
+ Hits 4098 4106 +8
- Misses 61 72 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Closing this as we're going to go a different route with comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC5546 allows for COMMENT properties on all iTIP methods. This PR attempts to extend the current implementation to suppot COMMENTs on REQUEST, REPLY and CANCEL methods currently implemented in the Broker.
Signed-off-by: Anna Larch anna@nextcloud.com